Fix DatePicker localization issues #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
date-picker - toolpad-db PR #1575
Render
Abandoned
oliviertassinari
temporarily deployed
to
date-picker - toolpad PR #1575
Render
Destroyed
oliviertassinari
temporarily deployed
to
date-picker - toolpad PR #1575
Render
Destroyed
bytasv
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to remove
onChangeHandler, then noticed a few bugs:formatunset. I fixed theLocalizationProviderand added async loading of locales. More locales to be added to the list. Locale detection has to be improved, this PR just suggests the methodology.@mui/toolpad-componentsas any, there seems to be an issue with our dependency tree. Never useas anyto "fix" problems that are not well understood. Use@ts-expect-errorand provide a path towards a solution. Usually it will be a link to a github ticket.valuevalueandonChangeto be a string