Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split browser and server js runtimes #1584

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Split browser and server js runtimes #1584

merged 5 commits into from
Jan 20, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 19, 2023 •
edited
Loading

Fix needed in #1521

Avoid quickjs-emscripten from contaminating the Toolpad runtime client bundles by splitting out server and browser runtime code. server runtime code will only be used

  • on the server
  • on the browser, but only in the editor, to simulate server runtime evaluation in the binding editor

@oliviertassinari oliviertassinari requested a deployment to split-jsruntimes - toolpad-db PR #1584 January 19, 2023 10:45 — with Render Abandoned
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 19, 2023
@oliviertassinari oliviertassinari temporarily deployed to split-jsruntimes - toolpad PR #1584 January 19, 2023 10:58 — with Render Destroyed
@Janpot Janpot marked this pull request as ready for review January 19, 2023 11:18
@Janpot Janpot enabled auto-merge (squash) January 19, 2023 11:24
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 19, 2023
@oliviertassinari oliviertassinari temporarily deployed to split-jsruntimes - toolpad PR #1584 January 19, 2023 15:02 — with Render Destroyed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 19, 2023
@Janpot Janpot disabled auto-merge January 20, 2023 10:13
@Janpot Janpot merged commit 5960a27 into master Jan 20, 2023
@Janpot Janpot deleted the split-jsruntimes branch January 20, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @oliviertassinari