Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick some changes from direction 13 branch #1599

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Cherrypick some changes from direction 13 branch #1599

merged 3 commits into from
Jan 26, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 25, 2023 •
edited
Loading

Cherry picking a few changes from #1521 to make it easier to stay in sync with master. These changes mostly center around reorganization to make it more straightforward to add conditional statements around parts of the code.

  • reorganize the app options menu to make it easier to individually disable certain menu items
  • reorganize the deploy button to make it easier to disable it as an individual unit
  • rename onRename to onRenameRequest to signify that this happens when a rename is requested, not when a rename has happened
  • add initialDom parameter to runtime to allow for preloading it with state
  • remove logic from canvas around basename that makes it harder to interchange with bare runtime
  • allow passing a catalog of precompiled components from the top-level of the runtime to bypass the compilation logic
  • avoid missing database url warning on startup. only fail when database is actually used
  • move createDefaultDom to the appDom module

@oliviertassinari oliviertassinari requested a deployment to cli-changes - toolpad-db PR #1599 January 25, 2023 10:05 — with Render Abandoned
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 25, 2023
@oliviertassinari oliviertassinari temporarily deployed to cli-changes - toolpad PR #1599 January 25, 2023 10:06 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to cli-changes - toolpad PR #1599 January 25, 2023 10:14 — with Render Destroyed
@Janpot Janpot marked this pull request as ready for review January 25, 2023 10:27
@Janpot Janpot enabled auto-merge (squash) January 25, 2023 10:27
apedroferreira
apedroferreira approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Janpot Janpot merged commit 19a5356 into master Jan 26, 2023
@Janpot Janpot deleted the cli-changes branch January 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @apedroferreira @oliviertassinari