Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove firefox specific branch in tests #1620

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Remove firefox specific branch in tests #1620

merged 5 commits into from
Feb 2, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 1, 2023 •
edited
Loading

Just to see which tests break

@oliviertassinari oliviertassinari requested a deployment to try-remove-ff-hack - toolpad-db PR #1620 February 1, 2023 10:49 — with Render Abandoned
@Janpot Janpot added test core Infrastructure work going on behind the scenes labels Feb 1, 2023
@Janpot Janpot changed the title Try remove firefox specific hack in tests Try remove firefox specific branch in tests Feb 1, 2023
@Janpot Janpot changed the title Try remove firefox specific branch in tests Remove firefox specific branch in tests Feb 1, 2023
@Janpot Janpot removed the core Infrastructure work going on behind the scenes label Feb 1, 2023
@Janpot Janpot mentioned this pull request Feb 1, 2023
Merged
@Janpot Janpot marked this pull request as ready for review February 1, 2023 12:31
apedroferreira
apedroferreira approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it works?
That's great! I think there must be something wrong with Playwright in my CLI because many tests fail in Firefox there, even excluding these ones...

@Janpot
Copy link
Member Author

Janpot commented Feb 1, 2023

Maybe it works differently dev vs production?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 1, 2023
@apedroferreira
Copy link
Member

Maybe it works differently dev vs production?

Yeah could be some difference between the CI environment and my local one.
Anyway that's just a local issue with my machine so I'll try to figure it out.

@oliviertassinari oliviertassinari temporarily deployed to try-remove-ff-hack - toolpad PR #1620 February 2, 2023 08:13 — with Render Destroyed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 2, 2023
@Janpot Janpot enabled auto-merge (squash) February 2, 2023 08:13
@Janpot Janpot merged commit 2a88ddb into master Feb 2, 2023
@Janpot Janpot deleted the try-remove-ff-hack branch February 2, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @apedroferreira @oliviertassinari