Hide resizable height prop controls #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
fix-datagrid-height - toolpad-db PR #1641
Render
Abandoned
apedroferreira
commented
Feb 8, 2023
| @@ -176,8 +176,6 @@ export default function NodeHud({ | |||
|
|
|||
| const hintPosition = rect.y > HUD_HEIGHT ? HINT_POSITION_TOP : HINT_POSITION_BOTTOM; | |||
|
|
|||
| const iconSx = { opacity: 0.7 }; | |||
There was a problem hiding this comment.
Unrelated, but the opacity i had added here made the icons seem disabled.
oliviertassinari
temporarily deployed
to
fix-datagrid-height - toolpad PR #1641
Render
Destroyed
oliviertassinari
temporarily deployed
to
fix-datagrid-height - toolpad PR #1641
Render
Destroyed
2 tasks
github-actions
bot
added
the
PR: out-of-date
apedroferreira
force-pushed
the
fix-datagrid-height
branch
from
d82c785
to
f0d5691
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
requested a deployment
to
fix-datagrid-height - toolpad-db PR #1641
Render
Abandoned
|
@Janpot Layout props weren't bindable already so I think this should be a good fix for these issues? |
oliviertassinari
temporarily deployed
to
fix-datagrid-height - toolpad PR #1641
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1277
Fixes #1614 too? (and also hides bindings button for "columns" props)
Very simple solution, but hiding the control in the properties panel for this type of prop seems to completely fix the issues?
Preview: https://toolpad-pr-1641.onrender.com/