Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Landing page design tweaks #1786

Merged
merged 23 commits into from
Apr 14, 2023
Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Mar 23, 2023

While skimming the current Toolpad landing page, I realized we have some tiny yet impactful design refinement opportunities we could make. Some of these styles are novel to this page eventually we'll bring them on to the others.

  • Haven't really changed the content of anything, it's just the design/layout.
    • The biggest exception is the removal of the "Get started" button from the hero. I was feeling like the stacked layout and two buttons were competing as to what was the main action the hero section is promoting. As we already promote the docs elsewhere in the page, focusing on capturing emails there only seems like a better direction, and it's also cleaner.
  • I've created some new components and left old ones commented on. There's still code clean-up/linting stuff to correct.

👉 https://deploy-preview-1786--mui-toolpad-docs.netlify.app/toolpad/

@danilo-leal danilo-leal added the website Related to the marketing pages label Mar 23, 2023
@danilo-leal danilo-leal marked this pull request as ready for review March 30, 2023 14:59
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @danilo-leal! Thanks for this 🙏 🥳

@danilo-leal
Copy link
Contributor Author

Just a note that, this last commit (264bb2f) pulled a lot of changes that weren't necessarily meant to be here! So, let me know if removing them is needed or if it's fine to leave them. I don't really know why they were picked up!

@apedroferreira
Copy link
Member

apedroferreira commented Mar 31, 2023

Just a note that, this last commit (264bb2f) pulled a lot of changes that weren't necessarily meant to be here! So, let me know if removing them is needed or if it's fine to leave them. I don't really know why they were picked up!

We really shouldn't merge those, they're files we recently deleted :D
If everything in that commit was added unintentionally we can probably just revert that commit in this PR.
(Just reverted and merged master again, looks fine now)

BTW the design changes look great!

Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great work!

@danilo-leal danilo-leal merged commit 69feee6 into master Apr 14, 2023
@danilo-leal danilo-leal deleted the landing-page-design-tweaks branch April 14, 2023 16:51
@prakhargupta1
Copy link
Member

Thanks Danilo for these inputs! Looks great :)

Copy link
Member

@gerdadesign gerdadesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilo-leal Just noting from this PR that the alpha label is no longer consistent throughout the site. Fine to adjust it, but we should make sure it's adjusted everywhere, including the Figma components, too!

ToolpadLP

Products

Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Related to the marketing pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants