Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imports from toolpad #1793

Merged
merged 8 commits into from
Mar 24, 2023
Merged

Fix imports from toolpad #1793

merged 8 commits into from
Mar 24, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 23, 2023 •
edited
Loading

  • Only install @mui/toolpad and not @mui/toolpad-core from create-toolpad-app
  • Provide @mui/toolpad/browser and @mui/toolpad/server and make sure they're dual mode commonjs/esm packages
  • Update docs
  • Update code generators to emit import { createQuery } from '@mui/toolpad/server' instead of @mui/toopad-core

See #1653
Closes #1667

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Mar 23, 2023
@Janpot Janpot mentioned this pull request Mar 23, 2023
Closed
7 tasks
@Janpot Janpot marked this pull request as ready for review March 24, 2023 07:42
@Janpot Janpot merged commit aa1e2a0 into master Mar 24, 2023
@Janpot Janpot deleted the fix-import-from-toolpad branch March 24, 2023 14:18
bharatkashyap
bharatkashyap reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap left review comments

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reach consensus on APIs
2 participants
@Janpot @bharatkashyap