Use worker scoped fixtures for integration tests #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
Merged
| @@ -10,4 +10,6 @@ export async function gotoIfNotCurrent( | |||
| if (pathname !== expectedPath) { | |||
| await page.goto(expectedPath, opts); | |||
| } | |||
|
|
|||
| await page.waitForURL((url) => url.pathname === expectedPath); | |||
There was a problem hiding this comment.
Would it work to replace all instances of page.waitForNavigation with this page.waitForURL?
I think that's what Playwright is recommending now anyway.
We could probably do it in a separate PR though.
There was a problem hiding this comment.
Yes, I already did a batch in #1699. Thought I had all of them.
But let's keep that for a follow up indeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid restarting the same fixture server over and over again for different tests in the same file. This starts just one server per test file. this allows us to reuse the running server for multiple tests creating less overhead