Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Toolpad app migration on startup #1832

Merged
merged 11 commits into from
Mar 30, 2023
Merged

Do Toolpad app migration on startup #1832

merged 11 commits into from
Mar 30, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 29, 2023

Working towards setting up migrating to pages folder. The current flow just transitions the DOM file on the fly every time it reads. This becomes a lot more complex once we start reading and writing to multiple files.
I'm changing the flow to only migrate once during startup of Toolpad dev and that will also the place where we transform the current app dom to a pages folder for #1831

@Janpot Janpot marked this pull request as ready for review March 30, 2023 08:34
@Janpot
Copy link
Member Author

Janpot commented Mar 30, 2023

Merging this to get unstuck for #1831
Reviews still accepted

@Janpot Janpot merged commit d283e54 into master Mar 30, 2023
@Janpot Janpot deleted the migrate-on-startup branch March 30, 2023 08:54
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants