Fix broken theming #1834
Fix broken theming #1834
Conversation
|
Wait I can probably add a test too. Will do in this PR. |
| fontSize: `3.25rem`, | ||
| fontWeight: 800, | ||
| }, | ||
| return createTheme( |
There was a problem hiding this comment.
Would just the following work? Not sure why I did that, but it doesn't make a lot of sense to me.
createTheme({
palette,
typography: {
// ...
}
})
👍 Just a smoke test of an app with a dark theme should be fine. Not that useful to add tests for the theme editor at this point I believe. |
| @@ -75,6 +77,8 @@ export class ToolpadEditor { | |||
| this.componentCatalog = page.getByTestId('component-catalog'); | |||
| this.componentEditor = page.getByTestId('component-editor'); | |||
|
|
|||
| this.themeEditor = page.getByTestId('theme-editor'); | |||
There was a problem hiding this comment.
I meant to not test the theme editor, but ok 😄
There was a problem hiding this comment.
Oh, you meant just starting with dark theme... I thought you meant testing light/dark theme was ok but not UI colors as those could change more later.
Anyway even if we change things later I guess some of these could still be useful, if not we'll eventually delete some of this and that's fine.
Status: Still going to add a test so leaving this PR in draft until then.
Closes #1814.
Themes were not working - this fix seems to work.
The regression was introduced in #1627 - it looks like deep merging the palette like that does not work, so we have to override it in the theme object? @Janpot