Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing extraneous dependencies #1885

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Add missing extraneous dependencies #1885

merged 2 commits into from
Apr 13, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 13, 2023 •
edited
Loading

glob as a dev dependency causes issues with starting toolpad as it's not finding the right dependency:

info  - starting Toolpad application in dev mode...
ready - toolpad project /Users/janpotoms/Projects/mui-contributor-dashboard/tools-public ready on http://localhost:3000
error - Failed to intialize Toolpad
TypeError: (0 , glob__WEBPACK_IMPORTED_MODULE_7__.glob) is not a function
    at calculateDomFingerprint (/Users/janpotoms/Projects/mui-contributor-dashboard/tools-public/node_modules/@mui/toolpad-app/.next/server/chunks/5698.js:2343:67)
    at initProject (/Users/janpotoms/Projects/mui-contributor-dashboard/tools-public/node_modules/@mui/toolpad-app/.next/server/chunks/5698.js:2374:9)

Adding a lint rule to detect those and fix some more missing ones

@Janpot Janpot added bug 🐛 Something doesn't work regression A bug, but worse labels Apr 13, 2023
@Janpot Janpot changed the title Glob must be a dependency instead of dev dependency Add missing extraneous dependencies Apr 13, 2023
@Janpot Janpot merged commit 82895ed into master Apr 13, 2023
@Janpot Janpot deleted the glob-dep branch April 13, 2023 09:43
@Janpot
Copy link
Member Author

Janpot commented Apr 13, 2023

Merging this as I want to release the fix ASAP

@Janpot Janpot removed the bug 🐛 Something doesn't work label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Janpot