Use npm registry to check for new versions #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
|
|
||
| export type PackageManager = 'npm' | 'yarn' | 'pnpm'; | ||
|
|
||
| async function detectPackageManager() { |
There was a problem hiding this comment.
https://github.com/mui/mui-toolpad/blob/master/packages/create-toolpad-app/src/index.ts#L8 Might be an easier way to do this?
There was a problem hiding this comment.
That would only work if toolpad was started through a package manager script though, it's slightly different here, I'd like to find out what package manager was used to author their project. e.g. they may run npx @mui/toolpad on a project that was installed with yarn. We want to propose yarn in that case, not npm
bharatkashyap
approved these changes
Apr 19, 2023
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to get 403 errors on the getLatestVersion check. This PR proposes to use the npm registry is the source of truth to check for new versions. It also proposes a CLI command instead of opening the installation docs
Screen.Recording.2023-04-14.at.17.13.52.mov