Deprecate createQuery and replace with createFunction
#1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
reviewed
Apr 18, 2023
| export const TOOLPAD_FUNCTION = Symbol.for('ToolpadFunction'); | ||
| /** | ||
| * @deprecated | ||
| * TOOLPAD_QUERY is deprecated. Use TOOLPAD_FUNCTION instead. |
There was a problem hiding this comment.
TOOLPAD_QUERY is not public API, you can just rename
Janpot
reviewed
Apr 18, 2023
| /** | ||
| * @deprecated | ||
| * createQuery is deprecated. Use createFunction instead. | ||
| */ | ||
| export default function createQuery<C extends CreateQueryConfig<CreateQueryConfigParameters<C>>>( |
There was a problem hiding this comment.
Is it possible to avoid duplication this way?
import createFunction from './createFuction'
/**
* @deprecated
* createQuery is deprecated. Use createFunction instead.
*/
const createQuery = createFunction
export default createQuery
Janpot
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating
createQueryin favour ofcreateFunction, and favouringfunctioninstead ofqueryin all related contexts to better follow the new nomenclature