Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form component #1926

Merged
merged 72 commits into from
Apr 24, 2023
Merged

Form component #1926

merged 72 commits into from
Apr 24, 2023

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Apr 21, 2023 •
edited
Loading

Will remerge to master after having reverted last week.
Now includes integration tests.
Previous merge: #1598

bytasv and others added 30 commits January 20, 2023 09:24
@bytasv
Add form component
16769dc
@bytasv
Merge branch 'master' into form-component
c2b2b03
@bytasv
Add form component
37bfae6
@bytasv
Replace with reac-hook-form
7289e9a
@bytasv
Merge branch 'master' into form-component
6bdab56
@bytasv
Merge branch 'master' into form-component
2f94fb0
@bytasv
Use a different form approach
855d8e9
@bytasv
Fix form value setting
6c7a51f
@bytasv
Merge branch 'master' into form-component
8981533
@bytasv
Use form context and form setter
32a72f5
@bytasv
Pull closest form for prop editor
1a37903
@bytasv
Fix controlled props editor
d0dd2d6
@bytasv
Hide form value control
8605f5c
@bytasv
Merge branch 'master' into form-component
2938d13
@bytasv
Fix lint errors
a95d9e6
@bytasv
tsignore error
46f693e
@apedroferreira
Merge remote-tracking branch 'origin/master' into form-component
362b53d
@apedroferreira
Basic functionality with react-hook-form
36497da
@apedroferreira
Store form values in scope
86271e7
@apedroferreira
Add functioning validation
7f37b80
@apedroferreira
Show validation errors, in-progress form reset
b6ce0da
@apedroferreira
Fix text, file and date components in forms
9211a7c
@apedroferreira
Fix date component
eab4144
@apedroferreira
Extra fix
a4ecfb8
@apedroferreira
Fix default values with resets in all form input components
7b6a1f5
@apedroferreira
Run validation when validation rules change
8cdb9fe
@apedroferreira
Add validation props to all inputs
5484531
@apedroferreira
Allow validation outside forms
6a7d987
@apedroferreira
Add prop categories and separate validation props
5764345
@apedroferreira
fix slow text input
55b3e85
apedroferreira and others added 18 commits March 24, 2023 17:48
@apedroferreira
Why didn't Prettier run
ee1ba95
@Janpot
Merge branch 'master' into form-component
3a87fa2 
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@apedroferreira
Replace all page root waits with waitForOverlay
e4b4c84
@apedroferreira
Merge remote-tracking branch 'origin/master' into form-component
2257a7b
@apedroferreira
Try to fix last merge
7ff5266
@apedroferreira
Fix tests
4d2a6d3
@apedroferreira
Fix tests more
3f0559d
@apedroferreira
Merge branch 'master' into form-component
0fbe5d6
@apedroferreira
Pass props directly + fallback field display name
ba56e7a
@apedroferreira
Fix container hover border
8d59461
@apedroferreira
Merge remote-tracking branch 'origin/master' into form-component
efc062a
@apedroferreira
Try test without waitFor
699e6cd
@apedroferreira
Test fix attempt
dd912eb
@apedroferreira
Merge remote-tracking branch 'origin/master' into form-component
08f1cc3
@apedroferreira
Fix isInteractive prop
f06e5f4
@apedroferreira
Fix interactive node issues
cdc220f
@apedroferreira
Merge remote-tracking branch 'origin/master' into form-component
408aa5b
@apedroferreira
Form component integration tests (#1916)
a42b2c3
@apedroferreira apedroferreira marked this pull request as ready for review April 21, 2023 17:30
@apedroferreira apedroferreira added new feature New feature or request feature: Components Button, input, table, etc. and removed new feature New feature or request labels Apr 21, 2023
@apedroferreira apedroferreira self-assigned this Apr 21, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 23, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2023
@apedroferreira apedroferreira merged commit 854056d into master Apr 24, 2023
@apedroferreira apedroferreira deleted the form-component branch April 24, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apedroferreira apedroferreira

Labels
feature: Components Button, input, table, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apedroferreira @bytasv @Janpot