Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate typeDef #1994

Merged
merged 6 commits into from
May 12, 2023
Merged

Deprecate typeDef #1994

merged 6 commits into from
May 12, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 10, 2023 •
edited
Loading

Simplify createComponent and createFunction by folding typeDef into the argument type

"myParam": {
  "typedef": { "type": "string" }
}

becomes

"myParam": {
  "type": "string"
}

I'm also adding a bunch of doc comments

@Janpot Janpot added the core Infrastructure work going on behind the scenes label May 10, 2023
@Janpot Janpot marked this pull request as ready for review May 10, 2023 16:45
@bharatkashyap
Copy link
Member

Do we need to write a migration for existing apps with custom components created via the old apps?

@Janpot
Copy link
Member Author

Janpot commented May 11, 2023

Do we need to write a migration for existing apps with custom components created via the old apps?

No, the old config will be accepted for a while, users will update manually

@Janpot Janpot enabled auto-merge (squash) May 12, 2023 10:46
@Janpot Janpot disabled auto-merge May 12, 2023 10:47
@Janpot Janpot enabled auto-merge (squash) May 12, 2023 10:48
@Janpot Janpot merged commit 0619214 into mui:master May 12, 2023
@Janpot Janpot deleted the deprecate-typeDef branch May 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @bharatkashyap