Split data binding page in docs #1996
Conversation
Let me know how it looks, also if it should be recorded in light mode.
Compressed gif with zooming
mp4 is 500KB while gif was 1MB. Also, I think having video controls is helpful as one can make it fullscreen, pause. This is just an ongoing experimentation, will further improve this.
| <!-- <img src="/static/toolpad/docs/data-binding/bind-16.gif" alt="Binding result" width="902px" // style="margin-bottom: 8px;" /> | ||
| !--> | ||
|
|
||
| <video autoplay muted loop playsinline controls> |
There was a problem hiding this comment.
Can you verify whether we're efficiently serving these videos? https://stackoverflow.com/a/10330501
There was a problem hiding this comment.
Yes, in the HTTP headers following conditions are being met: Content-Type: video/mp4 and Accept-Ranges: bytes, and no Content-Encoding.
The video was recorded in dark theme and as discussed yesterday, it should be in light theme so, we'll have to remove these commits.
| !--> | ||
|
|
||
| <video autoplay muted loop playsinline controls> | ||
| <source src="/static/toolpad/docs/data-binding/bind-17.mp4" type="video/mp4"> |
There was a problem hiding this comment.
Toolpad is in dark mode in this video
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com>
|
@prakhargupta1 Will you handle the rest of this PR? I can assign it to you. Let me know if I can help with anything else here or if there's anything else I could add or fix here. Also, we discussed that maybe "Data binding" should not be its own section, but be inside some other section?
|
|
In terms of docs structure, maybe we should just devote some sync meeting time and think about it holistically? In the meantime I don't think it should block merging this PR. It shouldn't be a big effort to rearrange pages afterwards. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@apedroferreira You can remove my commits as all of it was recorded in dark mode. I'll redo ot and create a separate PR. |
| @@ -1,6 +1,10 @@ | |||
| import * as React from 'react'; | |||
| import MarkdownDocs from 'docs/src/modules/components/MarkdownDocs'; | |||
| import { demos, docs, demoComponents } from '../../data/toolpad/data-binding.md?@mui/markdown'; | |||
There was a problem hiding this comment.
Deleted pages need a redirection, fixed in #2083
From #1954
Split data binding section in "binding state" and "event handling" pages.
https://deploy-preview-1996--mui-toolpad-docs.netlify.app/toolpad/data-binding/binding-state/
https://deploy-preview-1996--mui-toolpad-docs.netlify.app/toolpad/data-binding/event-handling/