Improve isolation of runtime from editor #2021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2016 uncovered that it's too easy mixing up runtime concerns with editor concerns. I'm working towards stronger isolating the two. Short term just within
@mui/toolpad-app
through enforcing some eslint rules, but further down the line it probably makes sense to replace the@mui/toolpad-core
and@mui/toolpad-components
with a@mui/toolpad-runtime
package to get a package topology that encourages better separation.Future topology
@mui/toolpad
=> CLI + set up toolpad server, imports@mui/toolpad-editor
@mui/toolpad-editor
=> Toolpad editor app, imports and wraps@mui/toolpad-runtime
@mui/toolpad-runtime
=> Toolpad app runtime only, also provides all encessary hooks the editor will need to wrap the runtime