Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade monorepo #2023

Merged
merged 6 commits into from
May 17, 2023
Merged

Conversation

bharatkashyap
Copy link
Member

No description provided.

@Janpot
Copy link
Member

Janpot commented May 16, 2023

mui/material-ui#37223

Looks like these started failing because the rule got disabled, not because the issues are resolved. I don't think we want this rule disabled

@bharatkashyap
Copy link
Member Author

mui/material-ui#37223

Looks like these started failing because the rule got disabled, not because the issues are resolved. I don't think we want this rule disabled

Do you mean keep the rules as-is and merge with a failing CI on test:lint?

@Janpot
Copy link
Member

Janpot commented May 17, 2023

Do you mean keep the rules as-is and merge with a failing CI on test:lint?

No, I think we need to look into why the rule got disabled in the first place and re-enable it for our code base. It looks like it got disabled in the top level config, but re-enabled in an override for performance reasons. We're not puling in the overrides, only the top-level config. Perhaps we can add a similar override to re-enable the rule?

.eslintrc.js Outdated
@@ -14,6 +14,7 @@ module.exports = {
rules: {
...baseline.rules,
'import/prefer-default-export': ['off'],
'import/no-cycle': ['error', { ignoreExternal: true }],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can use an override just like in https://github.com/mui/material-ui/pull/37223/files so that we benefit from the perf boost as well?

@bharatkashyap bharatkashyap merged commit 294ff06 into mui:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants