Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore warning for first-child pseudo selector in Markdown component #2034

Merged
merged 8 commits into from
May 18, 2023
Merged

Ignore warning for first-child pseudo selector in Markdown component #2034

merged 8 commits into from
May 18, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 17, 2023 •
edited
Loading

Fix warnings in the markdown component:

The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type".

We're not SSRing this so we can safely disable, also adding a test to catch the warning in the future

@Janpot Janpot added the core Infrastructure work going on behind the scenes label May 17, 2023
@Janpot Janpot changed the title Fix markdown warning about first-child Fix markdown warning for first-child pseudo selector in emotion May 17, 2023
@Janpot Janpot marked this pull request as draft May 17, 2023 11:52
@Janpot
Copy link
Member Author

Janpot commented May 17, 2023

Doesn't work

@Janpot Janpot closed this May 17, 2023
@Janpot Janpot reopened this May 17, 2023
@Janpot Janpot changed the title Fix markdown warning for first-child pseudo selector in emotion Ignore warning for first-child pseudo selector in Markdown component May 17, 2023
@Janpot Janpot marked this pull request as ready for review May 17, 2023 16:31
@Janpot Janpot enabled auto-merge (squash) May 18, 2023 16:38
@Janpot Janpot merged commit 7287043 into mui:master May 18, 2023
@Janpot Janpot deleted the md-warning branch May 18, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @apedroferreira