Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid too many binding evaluations in the runtime #2142

Merged
merged 22 commits into from
Jun 12, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 7, 2023

Closes #2139

  • evaluate all bindings only once per scope per render
  • encapsulate runtime scope and set up a parent/child relationship. Basically we use the same primitives for local scope as we use for global scope
  • update binding editor to understand scopes
  • expand test suite with more test cases testing
    • access local from local
    • set local from local
    • access global from local
    • set global from local

Notes

  • Why do textfields call onChange during mount?

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jun 7, 2023
@Janpot Janpot marked this pull request as ready for review June 8, 2023 10:48
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2023
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 9, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 9, 2023
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 10, 2023
@Janpot Janpot enabled auto-merge (squash) June 12, 2023 08:44
@Janpot Janpot merged commit 32e9b0a into mui:master Jun 12, 2023
@Janpot Janpot deleted the fix-performance branch June 12, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance degradation on the example app
1 participant