Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid serializations in queries #2163

Merged
merged 6 commits into from
Jun 14, 2023
Merged

Fix invalid serializations in queries #2163

merged 6 commits into from
Jun 14, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 12, 2023

Ran into all of these while building example applications

  • kill the process when the function worker fails unexpectedly
  • anticipate invalid results of functions
    • circular objeccts
    • objects containing non-serializable prooperties
    • invalid errors being thrown

@Janpot Janpot added the bug 🐛 Something doesn't work label Jun 13, 2023
@Janpot Janpot marked this pull request as ready for review June 13, 2023 10:16
@Janpot Janpot enabled auto-merge (squash) June 14, 2023 16:05
@Janpot Janpot merged commit 6661d30 into mui:master Jun 14, 2023
@Janpot Janpot deleted the function-serialization branch June 14, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @apedroferreira