Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing double dollars in the inlined DOM #2165

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Fix passing double dollars in the inlined DOM #2165

merged 4 commits into from
Jun 13, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 13, 2023 •
edited
Loading

Avoid string.replace seeing $$ as an escaped $ by using a replacer function

'hello'.replace('hello', '$$')
// '$'
'hello'.replace('hello', () => '$$')
// '$$'

Also fixing this for fileReplace and fileReplaceAll

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jun 13, 2023
@Janpot Janpot mentioned this pull request Jun 13, 2023
Merged
@Janpot Janpot marked this pull request as ready for review June 13, 2023 10:43
@Janpot Janpot merged commit a76358b into mui:master Jun 13, 2023
@Janpot Janpot deleted the double-dollars branch June 13, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @apedroferreira