-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add page structure explorer #2246
Merged
Merged
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8ab8842
WIP page structure explorer
bharatkashyap 26b3132
WIP add page structure explorer
bharatkashyap f37f538
v1 page structure explorer
bharatkashyap aeedf77
don't crash on renderItem node
bharatkashyap f7b6dfa
Merge branch 'master' into page-tree-view
bharatkashyap 46b0059
Merge branch 'master' into page-tree-view
bharatkashyap 587d5b3
Fix: Make side panel leaner
bharatkashyap 108ff97
Fix: better nested element expansion, delete on backspace
bharatkashyap b76a300
Merge branch 'master' of github.com:mui/mui-toolpad into page-tree-view
bharatkashyap 72a8f2b
Fix: accidental commit
bharatkashyap 964cc01
[WIP] Extract normalize function
bharatkashyap aad5904
Fix: Remove unnecessary ternary through type check
bharatkashyap 34ad45c
Extract delete functions for reusability
bharatkashyap ae60aa1
Merge branch 'master' of github.com:mui/mui-toolpad into page-tree-view
bharatkashyap f3d2109
Merge branch 'master' into page-tree-view
bharatkashyap 37e3691
Revert "[WIP] Extract normalize function"
bharatkashyap 02fa34e
Revert "Extract delete functions for reusability"
bharatkashyap b37715b
only make call to appStateApi, parallel effort ongoing
bharatkashyap f1b5705
Merge branch 'master' of github.com:mui/mui-toolpad into page-tree-view
bharatkashyap 19dafdd
fix: better scrollbars
bharatkashyap e634a33
Merge branch 'master' into page-tree-view
bharatkashyap 3191ae2
Merge branch 'master' of github.com:mui/mui-toolpad into page-tree-view
bharatkashyap b2badeb
Merge branch 'master' into page-tree-view
bharatkashyap 078a4d8
Merge branch 'master' into page-tree-view
bharatkashyap 5ce4365
Merge branch 'master' into page-tree-view
bharatkashyap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the dashed border doesn't really just mean the element is "hovered" anymore we might want to give this prop a different name just to avoid confusion. Maybe
isPreviewed
? Not sure, also not a super big deal.I understand this would have to change the wording in a lot of places now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
isHovered
captures the state still, since the user is "hovering" over the element albeit inside the structure explorer, so an indirect form of hovering.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think it's fine to keep it.