Avoid running the server in a separate process #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
changed the title
Janpot
changed the title
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2340
This PR builds further on #2354 and concludes the memory improvements for #2340
This refactor is aiming at removing the "server" process. The only real reason it is still there is because a big chunk of toolpad expects the project directory location to be available in a
TOOLPAD_PROJECT_DIRenvironment variable. We set this variable when starting the process. If we want to remove the process, we will need to first remove the reliance on this global variable.The bulk of this PR is a refactor to inject the toolpad project everywhere on the backend instead of reading it from the environment
before (local):
3 toolpad processes totalling to roughly 250m
after:
2 toolpad processes totalling to roughly 190m
Which is about 25% decrease in memory