Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve undo/redo test flakyness #2455

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Improve undo/redo test flakyness #2455

merged 1 commit into from
Aug 8, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 8, 2023

Can't really replicate the flakyness locally but I think we should only start the timeout after we've verified that the page has processed the change. The update only being processed on the page when we're already 450ms into the timeout could explain the flakyness I'm seeing in some test results

@Janpot Janpot added the test label Aug 8, 2023
@Janpot Janpot changed the title Try to improve undo/redo flakyness Improve undo/redo test flakyness Aug 8, 2023
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it makes the test less flaky this makes sense.
I also don't remember exactly why we're still debouncing on undo/redo, we should probably be able to get rid of it since the DOM changes are "atomic".

@Janpot Janpot merged commit b8b3136 into mui:master Aug 8, 2023
@Janpot Janpot deleted the undoredoflaky branch August 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants