[Toolpad Editor] Add themes docs link to theme panel #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +101,13 @@ export default function ComponentPanel({ className }: ComponentPanelProps) { | |||
| )} | |||
| </TabPanel> | |||
| <TabPanel value="theme" className={classes.panel}> | |||
| <Typography className={classes.themesDocsLink} variant="body2"> | |||
| Customize the app with a MUI theme. Read more about this in the{' '} | |||
| <Link href="https://mui.com/toolpad/concepts/theming" target="_blank" rel="noopener"> | |||
There was a problem hiding this comment.
This is a 301, slowing down the page load speed.
Suggested change
| <Link href="https://mui.com/toolpad/concepts/theming" target="_blank" rel="noopener"> | |
| <Link href="https://mui.com/toolpad/concepts/theming/" target="_blank" rel="noopener"> |
Fixed in ddffda5
| @@ -97,6 +101,13 @@ export default function ComponentPanel({ className }: ComponentPanelProps) { | |||
| )} | |||
| </TabPanel> | |||
| <TabPanel value="theme" className={classes.panel}> | |||
| <Typography className={classes.themesDocsLink} variant="body2"> | |||
| Customize the app with a MUI theme. Read more about this in the{' '} | |||
There was a problem hiding this comment.
It's uses Material UI:
Suggested change
| Customize the app with a MUI theme. Read more about this in the{' '} | |
| Customize the app with a Material UI theme. Read more about this in the{' '} |
Fixed in ddffda5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2561
This PR targets to add docs link to the theme panel which will allow users to directly jump to the right docs from the tool itself.
Usage :
Added Typography with variant as "body2" as it was looking perfect , body1 look inconsistent and larger in the side panel.
Imported and added Link component which points to the Docs page which opens in new page with rel "noopener"
Screenshots
Dark Mode without theme selector :
Dark Mode with theme selector :
Light Mode without theme selector :
Light Mode with theme selector :