Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Replace some images, gifs with videos #2662

Merged
merged 15 commits into from
Sep 14, 2023

Conversation

prakhargupta1
Copy link
Member

No description provided.

@prakhargupta1 prakhargupta1 changed the title Replace some images with videos [docs] Replace some images, gifs with videos Sep 11, 2023
@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Sep 11, 2023
@prakhargupta1 prakhargupta1 marked this pull request as draft September 11, 2023 09:24
@prakhargupta1 prakhargupta1 requested a review from a team September 11, 2023 14:36
@prakhargupta1 prakhargupta1 marked this pull request as ready for review September 11, 2023 14:36
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the videos are definitely more useful than the images!
The only thing I noticed is that maybe some of them are too fast? Such as the one about theming. We do want to keep the videos short but maybe we can make it a bit easier for someone new to follow without having to pause the video?

@prakhargupta1
Copy link
Member Author

I think the videos are definitely more useful than the images! The only thing I noticed is that maybe some of them are too fast? Such as the one about theming. We do want to keep the videos short but maybe we can make it a bit easier for someone new to follow without having to pause the video?

I purposely made them 2x to reduce their size. I agree, users will have to pause and that's what I like about video over gifs.

prakhargupta1 and others added 2 commits September 12, 2023 11:03
Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com>
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
## Adding components
1. Open the component library and drag a component over the canvas.
2. The canvas will highlight the location where the component can be dropped. Release the mouse to drop it.
3. To select a component, click on it either in the canvas or in the page hierarchy explorer. An overlay indicates the selected component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to link the word "page hierarchy explorer" to a doc describing what it is and how to find it?

@Janpot
Copy link
Member

Janpot commented Sep 12, 2023

Add some comments with what I think makes it more readable

prakhargupta1 and others added 3 commits September 13, 2023 14:12
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
@prakhargupta1 prakhargupta1 enabled auto-merge (squash) September 14, 2023 06:34
@prakhargupta1 prakhargupta1 merged commit 0c05f1a into mui:master Sep 14, 2023
9 checks passed
@prakhargupta1 prakhargupta1 deleted the replace-images-with-videos branch September 14, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants