Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format component and function #2665

Merged
merged 7 commits into from
Sep 13, 2023
Merged

format component and function #2665

merged 7 commits into from
Sep 13, 2023

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Sep 12, 2023

#2585

image
image

  • I've read and followed the contributing guide on how to create great pull requests.
  • I've updated the relevant documentation for any new or updated feature
  • I've linked relevant GitHub issue with "Closes #"
  • I've added a visual demonstration under the form of a screenshot or video

@JerryWu1234 JerryWu1234 changed the title format component format component and function Sep 12, 2023
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Sep 12, 2023
@JerryWu1234 JerryWu1234 marked this pull request as ready for review September 12, 2023 11:56
@JerryWu1234
Copy link
Contributor Author

@Janpot does your review finish? Anything else ?

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is looking good! If you're up to it can you bring back the return types?

@JerryWu1234
Copy link
Contributor Author

why not .
Let me fix it tomorrow

@JerryWu1234
Copy link
Contributor Author

Thank you, this is looking good! If you're up to it can you bring back the return types?

Last PR you told me that you also want to format the function and the component.

And tell me any demand please tell me

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great! I've removed the tryFormat function as we don't use it anymore.

I've added one more item in #2585. The bindings editor formats expressions, this is a bit more challenging since we run this in the browser, we'll have to read the config on the server and pass it to the frontend.

@Janpot Janpot enabled auto-merge (squash) September 13, 2023 07:09
@Janpot Janpot merged commit ef73083 into mui:master Sep 13, 2023
7 of 9 checks passed
@JerryWu1234
Copy link
Contributor Author

Thank you, this is great! I've removed the tryFormat function as we don't use it anymore.

I've added one more item in #2585. The bindings editor formats expressions, this is a bit more challenging since we run this in the browser, we'll have to read the config on the server and pass it to the frontend.

ok I will continue to follow up on this issue

@JerryWu1234
Copy link
Contributor Author

Thank you, this is great! I've removed the tryFormat function as we don't use it anymore.

I've added one more item in #2585. The bindings editor formats expressions, this is a bit more challenging since we run this in the browser, we'll have to read the config on the server and pass it to the frontend.

@Janpot what way do we pass it to the frontend ? Could I create a new API or anything else?
do you have any demand?

@Janpot
Copy link
Member

Janpot commented Sep 13, 2023

You could add a getPrettierConfig method in the project. No need to specify a file, just resolve the prettier config at the project root. Pass it to the frontend and use it the same way we do with getVersionInfo.

@JerryWu1234 JerryWu1234 deleted the format_2585 branch September 14, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants