Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create-toolpad-app for absolute paths #2682

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Fix create-toolpad-app for absolute paths #2682

merged 7 commits into from
Sep 20, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 14, 2023 •
edited
Loading

  • Create a temporary test dir outside of the project folder and run the test there
  • Allow absolute paths as an argument to create-toolpad-app
  • Display cli output for debugging purposes

Ran into this in #2546

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Sep 15, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 15, 2023
@Janpot
Merge branch 'master' into cta-fix
522ee28 
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 15, 2023
@Janpot Janpot marked this pull request as ready for review September 15, 2023 15:09
@Janpot Janpot requested a review from a team September 15, 2023 15:09
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 17, 2023
@Janpot
Merge branch 'master' into cta-fix
a5b0a19 
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot enabled auto-merge (squash) September 18, 2023 08:54
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 18, 2023
@Janpot Janpot merged commit 9a4e40e into mui:master Sep 20, 2023
@Janpot Janpot deleted the cta-fix branch September 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @bharatkashyap