Global functions explorer and header #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e page creation UX match function creation
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
commented
Oct 12, 2023
| } from '@mui/material'; | ||
| import { Link, matchPath, useLocation } from 'react-router-dom'; | ||
|
|
||
| const DRAWER_WIDTH = 68; // px | ||
| const DRAWER_WIDTH = 44; // px |
There was a problem hiding this comment.
The sidebar was too bulky and a bit ugly, I think we can keep it smaller and simpler.
There was a problem hiding this comment.
Could always make it resizable :)
apedroferreira
changed the title
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
This should be good to merge, it's behind a feature flag, it was part of the progress towards having a global functions explorer as shown in the description. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI for global functions with explorer using the new
EditableTreeItemcomponent, and empty views.We can merge already under the feature flag to keep things more separated.
Right now only works for function resources but we should discuss and see how to make it work for all types of resources, as we have data providers now.
Screen.Recording.2023-10-12.at.18.55.07.mov
Possible improvements: