Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vitest #2709

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Move to vitest #2709

merged 4 commits into from
Sep 22, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 22, 2023

  • Migrated test configs to vitest format
  • Migrated commands to use vitest run
  • Make sure imports are used everywhere instead of relying on the globals
  • Make sure testing library matchers work
  • Make sure console logging detection works
  • Changed one test which was testing whether an error was logged. Turns out it was faulty detecting an error related to the testing library.

@Janpot Janpot added the test label Sep 22, 2023
@Janpot Janpot changed the title [Wip] Move to vitest Move to vitest Sep 22, 2023
@Janpot Janpot marked this pull request as ready for review September 22, 2023 09:27
@Janpot Janpot requested a review from a team September 22, 2023 09:49
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had never heard about vitest, seems like a pretty straightforward replacement.
If it solves all the issues with ESM it sounds great!

@Janpot Janpot merged commit 3b73507 into mui:master Sep 22, 2023
@Janpot Janpot deleted the vitest branch September 22, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants