Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tilde character in create-toolpad-app project path #2725

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Sep 26, 2023

Fixes #2704

  • I've read and followed the contributing guide on how to create great pull requests.
  • I've updated the relevant documentation for any new or updated feature
  • I've linked relevant GitHub issue with "Closes #"
  • I've added a visual demonstration under the form of a screenshot or video

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I propose to rename getAbsoluteUrl it to bashResolvePath to be a bit more descriptive (it's not a url, and we're enhancing the standard node path.resolve with bash specific functionality) and add a comment with a link to https://www.gnu.org/software/bash/manual/html_node/Tilde-Expansion.html

Also, let's add the function in https://github.com/mui/mui-toolpad/blob/master/packages/toolpad-utils/src/path.ts?

packages/create-toolpad-app/src/util.ts Outdated Show resolved Hide resolved
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Sep 27, 2023
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Janpot Janpot merged commit 9596a8f into mui:master Sep 27, 2023
11 checks passed
@JerryWu1234 JerryWu1234 deleted the 2704_fix_hoem_path branch September 27, 2023 07:38
@Janpot Janpot changed the title fix 2704 Expand tilde character in create-toolpad-app projecy path Sep 27, 2023
@Janpot Janpot changed the title Expand tilde character in create-toolpad-app projecy path Expand tilde character in create-toolpad-app project path Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-toolpad-app doesn't expand the home folder
2 participants