Remove babel-plugin-transform-rename-import #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
changed the title
apedroferreira
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2546
Still have no idea what this construction with
babel-plugin-transform-rename-importis supposed to do. But it's failing under #2546 as not all import identifiers are to@mui/monorepo/packages/mui-utils/macros/MuiError.macroare writtent hat way. I'm replacing it with the babel macros setup from the front. Until we remove that altogether.babel operates on individual modules, it doesn't do anything around module resolution. We should leave aliasing to the tools that are concerned with linking modules together. i.e. bundlers