Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESM charts issues in production #2861

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Fix ESM charts issues in production #2861

merged 4 commits into from
Nov 3, 2023

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Nov 3, 2023 •
edited
Loading

Adding prop-types and react-dom to optimizeDeps seems to fix it indeed. Thanks @Janpot !

@apedroferreira apedroferreira added the bug 🐛 Something doesn't work label Nov 3, 2023
@apedroferreira apedroferreira self-assigned this Nov 3, 2023
@apedroferreira apedroferreira changed the title Temporary console log just to reproduce the issue Fix ESM charts issues in production Nov 3, 2023
@apedroferreira apedroferreira marked this pull request as ready for review November 3, 2023 15:31
@apedroferreira apedroferreira merged commit a378e3a into mui:master Nov 3, 2023
11 checks passed
@apedroferreira apedroferreira deleted the fix-esm-charts-issue branch November 3, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees

@apedroferreira apedroferreira

Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apedroferreira @Janpot