Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts example #2880

Merged
merged 3 commits into from
Nov 9, 2023
Merged

charts example #2880

merged 3 commits into from
Nov 9, 2023

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Nov 8, 2023

Preview:

Screen.Recording.2023-11-08.at.4.02.49.PM.mov

@prakhargupta1
Copy link
Member Author

@apedroferreira In the 4th chart, I see the values when I hover over the chart, but nothing visually shows on the chart area.

@apedroferreira
Copy link
Member

@apedroferreira In the 4th chart, I see the values when I hover over the chart, but nothing visually shows on the chart area.

For scatter charts the data has to be numbers in both axes, I think that's a limitation that x-charts imposes... I can add an error message maybe to improve UX though.

Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added just these suggestions.
Let me know if you have any more feedback about charts.

examples/charts/toolpad/pages/page/page.yml Outdated Show resolved Hide resolved
examples/charts/toolpad/pages/page/page.yml Outdated Show resolved Hide resolved
@prakhargupta1 prakhargupta1 added the examples Relating to /examples label Nov 8, 2023
@prakhargupta1 prakhargupta1 merged commit 5a0713e into mui:master Nov 9, 2023
11 checks passed
@prakhargupta1 prakhargupta1 deleted the charts-example branch November 10, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants