Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running multiple handlers side-by-side in a custom server #2882

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Nov 8, 2023

  • Change the meaning of Toolpad root to actually point to the ./toolpad project folder. That way we can allow you to use multiple within the same folder
  • We replace the default of . to ./toolpad to counter the removal of a path segment and avoid this being a breaking change
  • Remove the deprecation message of legacy projects. We can't detect this anymore. And it's not in use anymore for a long time
  • Relax the guard that allows to create only a single project instance to a per folder guard so multiple projects can run side by side in the same node.js process.
  • read .env file from cwd
  • introduce the --create option for CLI only as a protection against unintended project initialization

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Nov 8, 2023
@Janpot Janpot marked this pull request as ready for review November 8, 2023 17:33
@Janpot Janpot requested a review from a team November 8, 2023 17:33
@Janpot Janpot changed the title Support running multiple handlers side-by-side in a custrom server Support running multiple handlers side-by-side in a custom server Nov 9, 2023
@Janpot Janpot enabled auto-merge (squash) November 9, 2023 08:01
@Janpot Janpot merged commit 4e68923 into mui:master Nov 9, 2023
11 checks passed
@Janpot Janpot deleted the multiple-custom-servers branch November 9, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants