Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for HTTP requests secret handling #2951

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Update documentation for HTTP requests secret handling #2951

merged 3 commits into from
Dec 1, 2023

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Nov 30, 2023 •
edited by Janpot
Loading

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Nov 30, 2023
Janpot
Janpot approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote the whole section to be a bit more comprehensive and to reflect more acurately the new way of dealing with environment variables. I've added some video and updated screenshot.

@Janpot
Copy link
Member

Janpot commented Nov 30, 2023 •
edited
Loading

@JerryWu1234 As the original author of the feature, would you mind reviewing this as well?

@JerryWu1234
Copy link
Contributor

@JerryWu1234 As the original author of the feature, would you mind reviewing this as well?

no problem

@JerryWu1234
Copy link
Contributor

JerryWu1234 commented Dec 1, 2023 •
edited
Loading

it looks great.

image
By the way it would be better If I can see this video.

@prakhargupta1
Copy link
Member Author

Thanks. The video works in the docs. I'll merge it.

Screenshot 2023-12-01 at 2 09 59 PM

@prakhargupta1 prakhargupta1 merged commit 8c8ea7d into mui:master Dec 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation to be updated for env variable binding update
3 participants
@prakhargupta1 @Janpot @JerryWu1234