Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix dead link to live demo #3041

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 1, 2024

To reproduce the bug, go to https://mui.com/toolpad/examples/npm-stats/#check-out-the-live-app.

I used the opportunity to fix the redirection.


I landed here checking that I wouldn't break anything by deleting the example repo that is on Render, now that it moved to Railway:

Screenshot 2024-01-01 at 17 43 23

https://dashboard.render.com/usage/inv-cm932juv3ddc7381bgi0/view

Deleted.

Are there any objections to deleting the rest? It doesn't seem that we need:

Screenshot 2024-01-01 at 17 46 12

https://dashboard.render.com/


I looked a bit at moving completely out of Render.com, I have tried to move the MUI Toolpad apps to Railway, https://github.com/mui/mui-public/blob/master/tools-public/railway.toml, https://mui-publictools-public-production.up.railway.app. It looks ok, but there seems to be one main problem: https://docs.railway.app/guides/environments#how-come-my-github-pr-wont-deploy.

Railway will not deploy a PR branch from a user who is not in your team or invited to your project without their associated GitHub account.

It forces to add all the team members, so Render is likely still cheaper.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation bug 🐛 Something doesn't work labels Jan 1, 2024
@Janpot
Copy link
Member

Janpot commented Jan 2, 2024

Looking at our current memory usage:

Screenshot 2024-01-02 at 10 21 21
(this is for tools-public)

Can we scale these back to the starter plan? Or is the startup peak still blocking us? It would mean at least 3 apps going from 25$/month to 7$/month (tools-private, tools-public, npm-stats). Add to that the removal of toolpad,toolpad-demo services (2 times 15$/month) and removal of a service of a PR that seems to have gotten stuck (25$/month) that could reduce the overall bill with 109$/month

@apedroferreira
Copy link
Member

Can we scale these back to the starter plan? Or is the startup peak still blocking us? It would mean at least 3 apps going from 25$/month to 7$/month (tools-private, tools-public, npm-stats). Add to that the removal of toolpad,toolpad-demo services (2 times 15$/month) and removal of a service of a PR that seems to have gotten stuck (25$/month) that could reduce the overall bill with 109$/month

Yeah, with the memory usage improvements the $7/month instance should work!

@oliviertassinari
Copy link
Member Author

@Janpot It sounds like we can do this 👍

@oliviertassinari oliviertassinari merged commit 702ba21 into mui:master Jan 2, 2024
12 checks passed
@oliviertassinari oliviertassinari deleted the fix-link-demo branch January 2, 2024 17:10
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 2, 2024

Can we scale these back to the starter plan?

👍

the removal of toolpad,toolpad-demo services

I have worked on this. We still had a few apps depending on https://master--toolpad.mui.com, they are now all migrated. I have downgraded these two to the free plan. I would still like to see them, find it helpful to envision how things could look like.


Alright, it looks like the January bill is going to be a lot more sized to our needs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants