Authentication/authorization tests #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
changed the title
apedroferreira
commented
Jan 31, 2024
| @@ -98,18 +163,45 @@ export function createAuthHandler(project: ToolpadProject): Router { | |||
| tenantId: process.env.TOOLPAD_AZURE_AD_TENANT_ID, | |||
| }); | |||
|
|
|||
| const credentialsProvider = CredentialsProvider({ | |||
There was a problem hiding this comment.
I can move the mock results somewhere else maybe, if it feels weird to have them here like this.
Merged
apedroferreira
commented
Jan 31, 2024
Janpot
reviewed
Feb 1, 2024
Janpot
approved these changes
Feb 3, 2024
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for authentication and authorization, using the new
credentialsauthentication provider that takes username/password combinations (enabled just in test mode in this PR), and some mock users.Includes some refactors too, I saw many things to improve/fix while implementing tests.