Fix drag-and-drop when dragging outside components #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe a test? |
apedroferreira
commented
Feb 7, 2024
test/visual/components/index.spec.ts
Outdated
| @@ -112,20 +114,58 @@ test('showing drag-and-drop previews', async ({ page, argosScreenshot }) => { | |||
| await argosScreenshot('drop-preview-left', screenshotConfig); | |||
|
|
|||
| await page.mouse.move(...getDropPreviewTopCoordinates(inputBoundingBox!), { | |||
| steps: 10, | |||
| steps: 1, | |||
There was a problem hiding this comment.
10 steps was misleading, it wasn't really screenshotting the final state after the drag.
Yep I was gonna add it, added it now. |
apedroferreira
changed the title
Janpot
approved these changes
Feb 8, 2024
Nope they were wrong, these step numbers seem to influence certain screenshots... I fixed it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed recently that the drag-and-drop is buggy in some cases, it can probably be quite annoying and turn off some users... Added a fix and a test.
Not sure what changed to cause this problem, it seems like the page boxes used to include the margins but now they don't.
Before:
Screen.Recording.2024-02-07.at.18.03.13.mov
After:
Screen.Recording.2024-02-07.at.18.03.48.mov
I've seen some bad bugs with renaming nodes/pages too, will take a look at those next and create an issue if it's not quick.