Fix editable tree item bugs

[apedroferreira]

Fix some bugs seen in editable tree items:

• In pages explorer, since the items were changed to show page display names instead of node names, the renaming feature was confusing and could even cause pages to be deleted unintentionally. Fix: Changed the renaming to update display name instead of node name.
• In page hierarchy explorer, somehow clicking near the outside of an item triggered a blur event that cleared the editable input. Fix: I removed a state update to the value of this input that didn't seem like it was doing anything.
• When deleting a page that is not the active page from the explorer, Toolpad changed to an empty app screen.

Before:

Screen.Recording.2024-02-09.at.01.11.57.mov

After:

Screen.Recording.2024-02-09.at.01.09.45.mov

[Janpot]

Interesting. It feels a bit counterintuitive to me. Like, you have a page "users". And you rename it to "employees". Now you have "pages/users/page.yml" in the file system and "employees" in the editor file tree. Maybe we need to change the editor file tree back to use page name? And then show the display name in a tooltip?

[apedroferreira]

Interesting. It feels a bit counterintuitive to me. :Like, you have a page "users". And you rename it to "employees". Now you have "pages/users/page.yml" in the file system and "employees" in the editor file tree. Maybe we need to change the editor file tree back to use page name? And then show the display name in a tooltip?

Yeah originally when we added display names I thought the pages explorer would stay the same.
Let's change it back to showing the file names then but still show the display names somehow, a tooltip might work!

[Janpot]

Yeah originally when we added display names I thought the pages explorer would stay the same.

👍 I changed that, didn't give it enough thought

a tooltip might work

👍 another alternative is pageName (Display Name). But maybe that would create too long strings.

[apedroferreira]

Ok, looks like a Tooltip does the job, just not as immediately visible but I think that's fine?

Screen.Recording.2024-02-09.at.16.53.05.mov

[bharatkashyap]

Ok, looks like a Tooltip does the job, just not as immediately visible but I think that's fine?

Screen.Recording.2024-02-09.at.16.53.05.mov

This feels like the best option to me 👍