Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a data providers CRUD page to basic crud app example #3211

Merged
merged 14 commits into from
Feb 27, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Feb 13, 2024

  • After adding a record, the Add Record button goes into a disabled state and Edit, delete buttons disappear.
Screen.Recording.2024-02-27.at.11.17.45.AM.mov

@prakhargupta1 prakhargupta1 added the examples Relating to /examples label Feb 14, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One part of commented out code that can be removed. Looks good otherwise

@prakhargupta1
Copy link
Member Author

Does #3215 fix the issue in the video above?

@Janpot
Copy link
Member

Janpot commented Feb 14, 2024

Does #3215 fix the issue in the video above?

No, I'm looking into it

I'm tweaking it a bit further in that PR

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2024
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2024
@prakhargupta1
Copy link
Member Author

@Janpot In v0.1.50, the experience is the same as in the video above. Should I still merge this one for now?

@Janpot
Copy link
Member

Janpot commented Feb 26, 2024

@prakhargupta1 I found the problem, you were not returning a new record from createRecord and the grid didn't give good feedback. I'm adding a few tweaks to the grid to improve this behavior

@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Feb 27, 2024

@prakhargupta1 I found the problem, you were not returning a new record from createRecord and the grid didn't give good feedback. I'm adding a few tweaks to the grid to improve this behavior

Ah! Thanks, Looks perfect now.
Though I can't merge due to a failing integration test.

@Janpot
Copy link
Member

Janpot commented Feb 27, 2024

@prakhargupta1 fixed

@prakhargupta1 prakhargupta1 merged commit a7be716 into mui:master Feb 27, 2024
12 checks passed
@prakhargupta1 prakhargupta1 deleted the edit-example branch February 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants