-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MUI Toolpad to Toolpad Studio #3238
Conversation
a8331fb
to
b8bb879
Compare
@@ -35,8 +35,9 @@ async function waitForMatch(input: Readable, regex: RegExp): Promise<RegExpExecA | |||
}); | |||
} | |||
|
|||
test( | |||
'create-toolpad-app can bootstrap a Toolpad app', | |||
// @TODO: Unskip once @mui/toolpad-studio is released for the first time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can unskip this after we publish, the test fails because @mui/toolpad-studio
hasn't been published yet.
This should be it? Hopefully I didn't miss anything important as it's a lot of changes... I didn't update much on the docs as they're being worked on separately, we can sync them afterwards if it's needed. |
|
you can ignore vale errors for this PR as far as I'm concerned. @bharatkashyap |
It's ok i fixed them all, but yeah it was a bit much and too strict, there's a limit of 10 warnings too... |
I can't get that flaky test to pass, but it's unrelated to this PR... I'll work on fixing it next asap, feel free to review this so we can merge before there are more conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes let's keep this pr about renaming and fix preexisting issues separately
Exciting change ahead! |
The examples were all failing Fixed in 9003b91 |
Rename MUI Toolpad to Toolpad Studio.
Does not introduce breaking changes -
create-toolpad-app
creates an app using the renamed packages.