Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] add engines field to @mui/toolpad package.json #3254

Merged
merged 4 commits into from
Feb 27, 2024
Merged

[core] add engines field to @mui/toolpad package.json #3254

merged 4 commits into from
Feb 27, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Feb 27, 2024 •
edited by Janpot
Loading

closes #3158

wuls and others added 3 commits February 27, 2024 16:47
fix 3158 and add new field
360e0b9
@JerryWu1234
Update package.json
da4e26c 
Signed-off-by: Jerry_wu <409187100@qq.com>
@JerryWu1234
Update package.json
ff6f5a8 
Signed-off-by: Jerry_wu <409187100@qq.com>
@JerryWu1234 JerryWu1234 marked this pull request as ready for review February 27, 2024 08:49
@JerryWu1234
Update package.json
da99b97 
Signed-off-by: Jerry_wu <409187100@qq.com>
Janpot
Janpot approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Janpot Janpot added the enhancement This is not a bug, nor a new feature label Feb 27, 2024
@Janpot Janpot changed the title fix 3158 and add new field [core] add engines field to @mui/toolpad package.json Feb 27, 2024
@Janpot Janpot merged commit 4b62bf1 into mui:master Feb 27, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add engines field to package.json
2 participants
@JerryWu1234 @Janpot