Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment binding preview #3413

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix environment binding preview #3413

merged 1 commit into from
Apr 19, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 17, 2024 •
edited
Loading

Fixes #3410

The env var file is only a subset of the available vars.

  • Use the env var file keys for the warning message
  • Use the actual env for evaluation of preview
  • Show a preview of the actual value
  • Fix issues with the tab switching to expression when you empty the env value

Screenshot 2024-04-17 at 18 40 39

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Apr 17, 2024
@Janpot Janpot marked this pull request as ready for review April 17, 2024 17:00
@bharatkashyap
Copy link
Member

  • Does it make sense to have a more standard warning?
Screenshot 2024-04-18 at 3 00 50 PM

@Janpot
Copy link
Member Author

Janpot commented Apr 19, 2024

Does it make sense to have a more standard warning?

Maybe, but probably not within the scope of this PR. The message was already there, I just fixed some bugs around the binding editor for env vars.

@Janpot Janpot merged commit 7af3d2a into mui:master Apr 19, 2024
11 of 12 checks passed
@Janpot Janpot deleted the fix-env-vars branch April 19, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment variables are not propagated to HTTP query parameters
2 participants
@Janpot @bharatkashyap