Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from trying MUI ESM branch #3417

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Fix issues from trying MUI ESM branch #3417

merged 5 commits into from
Apr 22, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 18, 2024

Trying out mui/material-ui#41596 before we merge it and fixing some issues

  • Remove unused scripts. I initially fixed the failing resolution in it, but in the end it turned out to be unused.
  • Fix import of Grid2 which was too nested for some reason, probably vscode auto-import

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Apr 18, 2024
Comment on lines -11 to +10
import Grid2 from '@mui/material/Unstable_Grid2/Grid2';
import Grid2 from '@mui/material/Unstable_Grid2';
Copy link
Member

@oliviertassinari oliviertassinari Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding this to illustrate mui/material-ui#31096.

I'm also doing a step forward to be able to fail the CI mui/material-ui#41970

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 20, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2024
@Janpot Janpot marked this pull request as ready for review April 22, 2024 09:26
@Janpot Janpot requested a review from a team April 22, 2024 09:27
@Janpot Janpot merged commit 46cacbc into mui:master Apr 22, 2024
12 checks passed
@Janpot Janpot deleted the try-mui-esm branch April 22, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants