[docs] [ui] Make Pro badge style consistent #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bharatkashyap
commented
Apr 18, 2024
•
bharatkashyap
commented
- Make uppercase the standard for the "Pro" chip:
bharatkashyap
changed the title
Janpot
reviewed
Apr 18, 2024
| @@ -62,7 +62,7 @@ export function UpgradeChip({ | |||
| size="small" | |||
| clickable | |||
| label="Pro" | |||
| sx={sx} | |||
| sx={{ textTransform: 'uppercase', ...sx }} | |||
bharatkashyap
changed the title
bharatkashyap
changed the title
bharatkashyap
force-pushed
the
fix/pro-chip-docs
branch
from
98c4646
to
a6796bc
Compare
|
Olivier mentioned using "Pro" (and not pro, PRO) and he did the changes for X repo in mui/mui-x#12922 |
More than nomenclature this is a typography question, since text inside Chips is usually capitalised, as in on our docs as well:
We can continue to use "Pro" (instead of "pro" or "PRO") in the documentation text. |
Janpot
reviewed
Apr 29, 2024
packages/toolpad-studio/src/toolpad/AppEditor/UpgradeNotification.tsx
Outdated
Show resolved
Hide resolved
…ion.tsx Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.