Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run toolpad/core tests in the browser #3640

Merged
merged 17 commits into from
Jun 6, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 5, 2024

Historically, @toolpad/core has been using vitest for testing.
Latest vitest comes with browser testing out of the box which this PR enables for @toolpad/core. That way we can test X components that rely on a layout engine to be present more realistically

  • run @toolpad/core tests on vitest+playwright

@Janpot Janpot added the test label Jun 5, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 5, 2024
@Janpot Janpot marked this pull request as ready for review June 5, 2024 16:17
@Janpot Janpot requested a review from a team June 5, 2024 16:17
@Janpot Janpot merged commit 9d2dcc9 into mui:master Jun 6, 2024
13 checks passed
@Janpot Janpot deleted the browser-tests branch June 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant