Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Toolpad core landing page #3690

Merged
merged 18 commits into from
Jul 19, 2024

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Jun 17, 2024

@prakhargupta1 prakhargupta1 added the website Related to the marketing pages label Jun 17, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 19, 2024
Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 25, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 4, 2024
@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Jul 5, 2024

@Janpot In the features section of https://deploy-preview-3690--mui-toolpad-docs.netlify.app/toolpad/:

  1. I tried showcasing dashboard layout component like its done here: https://mui.com/toolpad/core/react-dashboard-layout/. Instead of coming in the iframe it comes over the entire page.
  2. Notifications snackbar throws some error.

Can you have a look please?

@Janpot
Copy link
Member

Janpot commented Jul 5, 2024

  1. There doesn't seem to be an iframe, so we'll have to wrap the component with something like https://github.com/mui/material-ui/blob/d03b6af3a2789af3c55db59f2991205a1f854103/docs/src/modules/components/DemoSandbox.js#L95. I won't have time to look into this before my holidays.
  2. If you're not using the Toolpad app provider, you'll have to wrap your page with a <NotificationsProvider> as per docs.

@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Jul 9, 2024

  1. There doesn't seem to be an iframe, so we'll have to wrap the component with something like https://github.com/mui/material-ui/blob/d03b6af3a2789af3c55db59f2991205a1f854103/docs/src/modules/components/DemoSandbox.js#L95. I won't have time to look into this before my holidays.

Thanks for the direction, I tried adding it, but couldn't make it work.

@apedroferreira
Copy link
Member

apedroferreira commented Jul 10, 2024

  1. I tried showcasing dashboard layout component like its done here: https://mui.com/toolpad/core/react-dashboard-layout/. Instead of coming in the iframe it comes over the entire page.

Can you have a look please?

Taking a look at this. Added a fix, just needed the iframe prop in DemoSandbox!

@Janpot Janpot self-requested a review July 15, 2024 12:13
@prakhargupta1 prakhargupta1 marked this pull request as ready for review July 15, 2024 13:15
@prakhargupta1 prakhargupta1 changed the title [docs] Add Toolpad core landing page [website] Add Toolpad core landing page Jul 15, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge this and fill in the blank demos later (page container, authentication)

@Janpot Janpot merged commit e8b6d87 into mui:master Jul 19, 2024
14 checks passed
@prakhargupta1 prakhargupta1 deleted the toolpad-core-landing-page branch September 30, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Related to the marketing pages
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants