Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add browserslistrc #3711

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[core] Add browserslistrc #3711

merged 1 commit into from
Jun 25, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 25, 2024 •
edited
Loading

  • I noticed the @toolpad/core build output contained unnecessary babel helpers. Added the missing .browserslistrc.
  • Fix double invocation of the prebuild script + add a predev script to clean the output folder before running the dev command.

@Janpot Janpot added core Infrastructure work going on behind the scenes and removed core Infrastructure work going on behind the scenes labels Jun 25, 2024
@Janpot Janpot marked this pull request as ready for review June 25, 2024 08:30
@apedroferreira
Copy link
Member

Looks good, for some reason the pre scripts didn't run automatically for me when I set this up unless I enabled a specific flag in .npmrc but they seem to work now.

@Janpot Janpot merged commit 574f8d3 into mui:master Jun 25, 2024
14 of 16 checks passed
@Janpot Janpot deleted the core-build branch June 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @apedroferreira